-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-10626: Drupalize new homepage components #11114
VACMS-10626: Drupalize new homepage components #11114
Conversation
…ual fields for better control.
@dsasser When running the GraphQL query in the explorer, this pop up comes up. Is that expected and if so, which one should I select? I get the following for all four so that piece looks like it's working:
|
There are 4 distinct queries. When you add all of them to the Graphql explorer and try to run them, it prompts you to select which query you are running. It is very buggy when doing this, I recommend adding in one query at a time as a result. |
I didn't have any issues running through the steps to add the new components and the output of the graphql queries was healthy, see output of my test items:
This looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the testing steps worked and I don't see any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I just want to declare what we talked about on zoom.
- Design review and ux guidance all that will come later
- user permissions will also happen later.
- The primary focus here is to get the fields in to the CMS, to unblock FE.
Also for archival purposes: we had talked about condensing the two block types into one, since they are both the same right now, but had discussed the likelihood/risk that the two blocks would need to diverge from each other. So this PR is hedging that bet.
| Products | products | Vocabulary | | | ||
| Topics | topics | Vocabulary | | | ||
| Type of Redirect | type_of_redirect | Vocabulary | | | ||
Scenario: Bundles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this formatting is the default formatting coming directly out of the spec tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it appears so, unfortunately. I poked around in phpstorm and didn't see any auto-format for behat feature files, but it could be that I just missed it. In the future I'll double check with a text editor.
Nice work on the QA steps |
Next time around, it is easy enough to change the target branch after the fact. The old PR could have been fine, no need to close. That would have kept all the comments and other history. Full disclosure, github makes it hard to find the option to change the target. |
cc406ae
into
department-of-veterans-affairs:integration-VACMS-8877-homepage-hardening-refresh
Thanks so much Steve. I thought this was possible, but it wasn't apparent how, and I avoided looking it up for some reason. |
* VACMS-10626: Add new benefits promo block type. * VACMS-10626: Add new home page hero entityqueue. * VAMCS-10626: Add owner field to benefit promo block. * VACMS-10626: Use select form widget for owner field. * VACMS-10626: Add other search tools menu. * VACMS-10626: Add popular on va.gov menu. * VACMS-10626: Add news promo custom block and related fields. * VACMS-10626: Add feature toggle for new homepage version. * VACMS-10626: Add homepage news spotlight entityqueue. * VACMS-10626: Add content model test changes. * VACMS-10626: Add menus test updates. * VACMS-10626: Add custom block fields to behat tests. * VACMS-10626: Update custom block fields behat test from spec tool output. * VACMS-10626: Update form display for news promo block. * VACMS-10626: Swap out link teaser for cta paragraph on news promo block. * VACMS-10626: Remove field_owner from new block types. * VACMS-10626: Add field_administration section field to new blocks. * VACMS-10626: Update guidance and character count formatting for new blocks. * VACMS-10626: Add image field to news promo block. * VACMS-10626: Replace alert block cta paragraph ref field with individual fields for better control. * VACMS-10626: Update behat spect tool test to reflect new content model changes. Co-authored-by: Daniel Sasser <[email protected]>
* VACMS-10626: Add new benefits promo block type. * VACMS-10626: Add new home page hero entityqueue. * VAMCS-10626: Add owner field to benefit promo block. * VACMS-10626: Use select form widget for owner field. * VACMS-10626: Add other search tools menu. * VACMS-10626: Add popular on va.gov menu. * VACMS-10626: Add news promo custom block and related fields. * VACMS-10626: Add feature toggle for new homepage version. * VACMS-10626: Add homepage news spotlight entityqueue. * VACMS-10626: Add content model test changes. * VACMS-10626: Add menus test updates. * VACMS-10626: Add custom block fields to behat tests. * VACMS-10626: Update custom block fields behat test from spec tool output. * VACMS-10626: Update form display for news promo block. * VACMS-10626: Swap out link teaser for cta paragraph on news promo block. * VACMS-10626: Remove field_owner from new block types. * VACMS-10626: Add field_administration section field to new blocks. * VACMS-10626: Update guidance and character count formatting for new blocks. * VACMS-10626: Add image field to news promo block. * VACMS-10626: Replace alert block cta paragraph ref field with individual fields for better control. * VACMS-10626: Update behat spect tool test to reflect new content model changes. Co-authored-by: Daniel Sasser <[email protected]> Co-authored-by: Daniel Sasser <[email protected]> Co-authored-by: Daniel Sasser <[email protected]>
Description
This PR originally started here: #11016. It was decided to move to an integration branch for the homepage updates, so this PR was created.
Closes #10626
Note that permissions, and field guidance text are ticketed separately. This PR addresses the ACs for #10626 only.
New Block Types:
Benefit Promo
News Promo
New Entity Queues:
Home page news spotlight
Home page hero
New Menus:
Other Search Tools
Popular on VA.gov
QA steps
Run GraphQL queries:
Validate GraphQL queries provide expected output:
Definition of Done
Select Team for PR review
Platform CMS Team
Sitewide program
⭐️ Sitewide CMS
⭐️ Public websites
⭐️ Facilities
⭐️ User support
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing annoucement
Is an announcement needed to let editors know of this change?