VACMS-19163: changed required astrisk to after #19882

jv-agile6 · 2024-11-15T15:24:59Z

Description

Relates to #19163

QA steps

name: "Campaign Landing Page - Spotlight Validation"

description: QA test for ensuring required fields and validation indicators appear correctly when editing a Campaign Landing Page, and that error messages are properly linked to the corresponding fields.

steps:

step: "Go to Tugboat instance Log in and create a new Campaign Landing Page."
expected_result: "Login and successfully go to create a Campaign Landing Page"
step: "Fill out the required fields in the Hero Banner, Why This Matters, What You Can Do, VA Benefits sections. and Selection settings"
expected_result: "Required fields are filled out without issues."

step: "Save as Published and save the node."
expected_result: "Node is saved successfully."

step: "Edit the node and enable the Spotlight section by clicking 'Enable this page segment.'"
expected_result: "Spotlight section is enabled."

step: "Check if the 'List of links with summaries' field is marked as required (red asterisk)."
expected_result: "The 'List of links with summaries' field is marked with a red asterisk."

step: "Add a Link teaser to the 'Links with summaries' field."
expected_result: "Link teaser is added successfully."

step: "Save the node again."
expected_result: "Node is saved successfully without errors."

expected_behavior:

"Required field 'List of links with summaries' should have a red asterisk."

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

github-actions · 2024-11-15T15:25:22Z

Checking composer.lock changes...

…inting fix 3

github-actions · 2024-11-15T15:31:08Z

Checking composer.lock changes...

github-actions · 2024-11-18T16:32:19Z

GitHub Workflows (.github/workflows/*.yml)

Have you...

pinned all affected GitHub Actions at a specific commit by SHA?
reviewed the source code of the action at the commit you are pinning?
confirmed that no GitHub security measures are being bypassed?
checked for any injection of user content into protected contexts?
reviewed Security hardening for GitHub Actions?
reviewed GitHub Workflows?

github-actions · 2024-11-18T16:32:19Z

Checking composer.lock changes...

…dSpotlightCLPrequired

github-actions · 2024-11-19T17:06:36Z

Checking composer.lock changes...

github-actions · 2024-11-20T20:38:29Z

Checking composer.lock changes...

dsasser

Some nitpicks, but also seeing duplicate required indicators on the link field:

dsasser · 2024-11-20T22:15:54Z

docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss

@@ -125,3 +125,9 @@
 #block-vagovclaro-content .paragraph.paragraph--type--magichead-group {
  border: var(--va-gray-lightest) solid 1px;
 }
+
+#field-clp-spotlight-link-teasers-values .form-item__label::after


NIT:
The opening bracket should go on this line.

dsasser · 2024-11-20T22:16:23Z

docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss

+
+#field-clp-spotlight-link-teasers-values .form-item__label::after
+{
+  color: #F00; /* Red color for the asterisk */


NIT:
Comments here are not necessary IMO. The styles speak for themselves here.

dsasser · 2024-11-20T22:18:01Z

docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss

+#field-clp-spotlight-link-teasers-values .form-item__label::after
+{
+  color: #F00; /* Red color for the asterisk */
+  content: "*"; /* Adds an asterisk before the label text */


SHOULD:
If you decide to leave the comments in, this will need to be updated to use after instead of before.

github-actions · 2024-11-21T14:54:26Z

Checking composer.lock changes...

jv-agile6 · 2024-11-21T15:03:10Z

Some nitpicks, but also seeing duplicate required indicators on the link field:

These styles are pre-exsiting from form.css

.form-item__label.form-required::after, .fieldset__label.form-required::after {
    display: inline-block;
    margin-inline: 0.15em;
    content: "*";
    color: var(--color-maximumred);
    font-size: 0.875rem;
}

github-actions · 2024-11-21T15:10:50Z

Checking composer.lock changes...

dsasser · 2024-11-21T21:59:17Z

docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss

@@ -125,3 +125,11 @@
 #block-vagovclaro-content .paragraph.paragraph--type--magichead-group {
  border: var(--va-gray-lightest) solid 1px;
 }
+
+#field-clp-spotlight-link-teasers-values .form-item__label::after {


This selector isn't completely accurate in that it is targetted even when the field isn't required. Is there some reason we can't add the [required] attribute to the selector?

I discovered the styles for the asterisk on form.css and was trying to follow it consistency. I can update and add [required].

github-actions · 2024-11-22T18:37:32Z

Checking composer.lock changes...

va-cms-bot · 2024-11-29T08:57:00Z

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

https://tugboat.vfs.va.gov/673767cff71289b6fbe5cceb

VACMS-19163: changed required astrisk to after

d410347

va-cms-bot temporarily deployed to Tugboat November 15, 2024 15:25 Destroyed

VACMS-19163: added required astrisk via css on paragraphs scss file-l…

a2e73e2

…inting fix 3

va-cms-bot temporarily deployed to Tugboat November 15, 2024 15:31 Destroyed

va-cms-bot temporarily deployed to Tugboat November 16, 2024 09:16 Destroyed

va-cms-bot temporarily deployed to Tugboat November 17, 2024 09:05 Destroyed

va-cms-bot temporarily deployed to Tugboat November 18, 2024 09:06 Destroyed

VACMS-19163: Refractored css selectors to apply required asterisk

caf5b3d

va-cms-bot temporarily deployed to Tugboat November 18, 2024 16:32 Destroyed

va-cms-bot temporarily deployed to Tugboat November 19, 2024 08:59 Destroyed

va-cms-bot temporarily deployed to Tugboat November 19, 2024 15:38 Destroyed

Merge remote-tracking branch 'origin/main' into VACMS-19163-Linksfiel…

f336fca

…dSpotlightCLPrequired

va-cms-bot temporarily deployed to Tugboat November 19, 2024 17:06 Destroyed

va-cms-bot temporarily deployed to Tugboat November 20, 2024 08:58 Destroyed

VACMS-19163: Updated scss selectors for specificity

3dd550d

va-cms-bot temporarily deployed to Tugboat November 20, 2024 20:38 Destroyed

jv-agile6 marked this pull request as ready for review November 20, 2024 21:22

jv-agile6 requested review from a team as code owners November 20, 2024 21:22

dsasser requested changes Nov 20, 2024

View reviewed changes

va-cms-bot temporarily deployed to Tugboat November 21, 2024 08:41 Destroyed

VACMS-19163: Refractored code form and removed comments

f6ed360

va-cms-bot temporarily deployed to Tugboat November 21, 2024 14:54 Destroyed

VACMS-19163: refractored for linting rules

9e3024f

va-cms-bot temporarily deployed to Tugboat November 21, 2024 15:10 Destroyed

dsasser reviewed Nov 21, 2024

View reviewed changes

va-cms-bot temporarily deployed to Tugboat November 22, 2024 08:41 Destroyed

VACMS-19163: changed style to target .form-item__description::after

a6e1f31

va-cms-bot temporarily deployed to Tugboat November 22, 2024 18:37 Destroyed

va-cms-bot temporarily deployed to Tugboat November 23, 2024 08:41 Destroyed

va-cms-bot temporarily deployed to Tugboat November 24, 2024 08:45 Destroyed

va-cms-bot temporarily deployed to Tugboat November 25, 2024 08:47 Destroyed

va-cms-bot temporarily deployed to Tugboat November 26, 2024 08:42 Destroyed

jilladams mentioned this pull request Nov 26, 2024

Links with summaries field in Spotlight section of CLP does not indicate it is required #19163

Open

3 tasks

va-cms-bot temporarily deployed to Tugboat November 27, 2024 08:46 Destroyed

va-cms-bot temporarily deployed to Tugboat November 28, 2024 08:42 Destroyed

va-cms-bot deployed to Tugboat November 29, 2024 08:42 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-19163: changed required astrisk to after #19882

VACMS-19163: changed required astrisk to after #19882

jv-agile6 commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 20, 2024

dsasser left a comment

dsasser Nov 20, 2024

dsasser Nov 20, 2024

dsasser Nov 20, 2024

github-actions bot commented Nov 21, 2024

jv-agile6 commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

dsasser Nov 21, 2024

jv-agile6 Nov 21, 2024

github-actions bot commented Nov 22, 2024

va-cms-bot commented Nov 29, 2024

VACMS-19163: changed required astrisk to after #19882

Are you sure you want to change the base?

VACMS-19163: changed required astrisk to after #19882

Conversation

jv-agile6 commented Nov 15, 2024 • edited Loading

Description

QA steps

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 18, 2024

GitHub Workflows (.github/workflows/*.yml)

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 20, 2024

dsasser left a comment

Choose a reason for hiding this comment

dsasser Nov 20, 2024

Choose a reason for hiding this comment

dsasser Nov 20, 2024

Choose a reason for hiding this comment

dsasser Nov 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

jv-agile6 commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

dsasser Nov 21, 2024

Choose a reason for hiding this comment

jv-agile6 Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 22, 2024

va-cms-bot commented Nov 29, 2024

jv-agile6 commented Nov 15, 2024 •

edited

Loading