vaos-service / VPG test organization

[devin-mccurdy]

Summary

In the process of changing many of the vaos module's vaos-service requests over to use VPG as a drop in replacement, we've ended up with duplicated tests and this PR is a first step in separating "new" vs "old" tests based on feedback from the platform team. It's helped find some gaps so that when we are eventually ready to remove "old" tests that we're not losing coverage.

• Tests making requests to vaos-service are moving into _old_spec.rb files. I'd intented to make these clearly deprecrated as _spec_old.rb but that causes them not to run (in addition to getting flagged by rubocop).

Related issue(s)

• https://app.zenhub.com/workspaces/appointments-oracle-health-integration-65a6e99ea522640e4d09393b/issues/gh/department-of-veterans-affairs/va.gov-team/94543

Testing done

• New code is covered by unit tests

[github-actions]

1 Error

🚫

This PR changes 4240 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files modules/mobile/spec/requests/mobile/v0/appointments/cancel_old_spec.rb (+59/-0) modules/mobile/spec/requests/mobile/v0/appointments/cancel_spec.rb (+11/-66) modules/mobile/spec/requests/mobile/v0/appointments/create_old_spec.rb (+112/-0) modules/mobile/spec/requests/mobile/v0/appointments/create_spec.rb (+2/-93) modules/mobile/spec/requests/mobile/v0/appointments/facilities/clinics_old_spec.rb (+170/-0) modules/mobile/spec/requests/mobile/v0/appointments/facilities/clinics_spec.rb (+2/-167) modules/mobile/spec/requests/mobile/v0/appointments/vaos_v2_old_spec.rb (+297/-0) modules/mobile/spec/requests/mobile/v0/appointments/vaos_v2_spec.rb (+1/-317) modules/vaos/spec/requests/vaos/v2/appointments_old_spec.rb (+669/-0) modules/vaos/spec/requests/vaos/v2/appointments_spec.rb (+2/-581) modules/vaos/spec/requests/vaos/v2/eligibility_old_spec.rb (+32/-0) modules/vaos/spec/requests/vaos/v2/eligibility_spec.rb (+2/-18) modules/vaos/spec/requests/vaos/v2/locations/clinics_old_spec.rb (+145/-0) modules/vaos/spec/requests/vaos/v2/locations/clinics_spec.rb (+17/-155) modules/vaos/spec/requests/vaos/v2/locations/slots_old_spec.rb (+49/-0) modules/vaos/spec/requests/vaos/v2/locations/slots_spec.rb (+2/-42) modules/vaos/spec/services/v2/appointment_service_old_spec.rb (+527/-0) modules/vaos/spec/services/v2/appointment_service_spec.rb (+2/-490) modules/vaos/spec/services/v2/patients_service_old_spec.rb (+36/-0) modules/vaos/spec/services/v2/patients_service_spec.rb (+5/-33) modules/vaos/spec/services/v2/systems_service_old_spec.rb (+65/-0) modules/vaos/spec/services/v2/systems_service_spec.rb (+2/-69) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[drewconnelly]

LGTM