namepace update from CentralMail to BenefitsIntake

[mreed101]

CentralMail namespaces within the 686 submission workflow have been updated to BenefitsIntake.

Summary

• This work is behind a feature toggle (flipper): NO
• CentralMail for for 686 has been renamed to BenefitsIntake to clear up confusion as we use lighthouse for handling submissions
• BenefitsIntake is more consistent and allows us to change service later on without the need to rename services or modules again
• VA Benefits and Claims
• (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

• 686 | Refactor code away from Central Mail va.gov-team#92235

Testing done

• New code is covered by unit tests
• The apps behavior does not change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• This is not a new feature

Screenshots

Note: Optional

What areas of the site does it impact?

Impacts are possible to form 686c submissions

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

We should throughly test the 686c workflow to ensure that all forms are being submitted properly and that logging is still accurate.

[github-actions]

1 Error

🚫

This PR changes 572 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .github/CODEOWNERS (+2/-3) app/controllers/claims_base_controller.rb (+1/-1) app/controllers/v0/burial_claims_controller.rb (+1/-1) app/serializers/{central_mail_submission_serializer.rb => benefits_intake_submission_serializer.rb} (+1/-1) app/services/bgs/dependent_service.rb (+5/-3) app/sidekiq/bgs/submit_form674_job.rb (+14/-5) app/sidekiq/bgs/submit_form686c_job.rb (+5/-3) app/sidekiq/central_mail/delete_old_claims.rb (+0/-16) app/sidekiq/central_mail/submit_central_form686c_job.rb (+0/-227) app/sidekiq/lighthouse/benefits_intake/delete_old_claims.rb (+18/-0) app/sidekiq/lighthouse/benefits_intake/submit_central_form686c_job.rb (+229/-0) app/sidekiq/lighthouse/income_and_assets_intake_job.rb (+2/-2) lib/dependents/monitor.rb (+1/-1) spec/lib/dependents/monitor_spec.rb (+2/-2) spec/serializers/{central_mail_submission_serializer_spec.rb => benefits_intake_submission_serializer_spec.rb} (+1/-1) spec/sidekiq/{central_mail => lighthouse/benefits_intake}/delete_old_claims_spec.rb (+1/-1) spec/sidekiq/{central_mail => lighthouse/benefits_intake}/submit_central_form686c_job_spec.rb (+13/-9) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[mreed101]

1 Error
🚫 This PR changes 531 LoC (not counting whitespace/newlines).
In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ.

File Summary
Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

A file was deleted from a previous folder and moved to a different one. The file in question was already over LoC which is leading to this error.

[evansmith]

@mreed101 can you go through app/services/bgs/dependent_service.rb, app/sidekiq/bgs/submit_form674_job.rb, and app/sidekiq/bgs/submit_form686c_job.rb to clear out the references to CentralMail::SubmitCentralForm686cJob

Also there are a few logs that link to datadog dashboards that reference CentralMail::SubmitCentralForm686cJob. Should those messages and dashboards be updated?

[mreed101]

@mreed101 can you go through app/services/bgs/dependent_service.rb, app/sidekiq/bgs/submit_form674_job.rb, and app/sidekiq/bgs/submit_form686c_job.rb to clear out the references to CentralMail::SubmitCentralForm686cJob

Also there are a few logs that link to datadog dashboards that reference CentralMail::SubmitCentralForm686cJob. Should those messages and dashboards be updated?

Modified in the latest commit.

[evansmith]

LGTM, thanks for adding those changes!