Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LH Benefits Claims code #19601

Closed
wants to merge 2 commits into from
Closed

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Nov 25, 2024

Summary

Lighthouse has determined that we should only have one set of client credentials that we use for all applications on va.gov. This pull request cleans up the code related to LH Benefits Claims to reflect this decision. I have left in code that allows for having specific credentials per LH service, as LH doesn't currently provide us with a good way to create a set of sandbox credentials that has access to all services currently.

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

get_intent_to_file

Code Search

get_intent_to_file

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this Nov 25, 2024
@@ -263,7 +240,7 @@ def filter_by_status(items)
end

def override_pmr_pending(claim)
tracked_items = claim['attributes']['trackedItems']
tracked_items = claim.dig('attributes', 'tracked_items')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're assuming that tracked_items might be nil, then we should also guard against attributes not existing as well

@va-vfs-bot va-vfs-bot temporarily deployed to lh-benefits-claims-cleanup/main/main November 25, 2024 22:18 Inactive
Copy link

github-actions bot commented Jan 2, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 2, 2025
Copy link

github-actions bot commented Jan 9, 2025

This PR has been closed because it has had no activity for 37 days

@github-actions github-actions bot closed this Jan 9, 2025
@github-actions github-actions bot deleted the lh-benefits-claims-cleanup branch January 9, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants