Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec coverage for form pages in the Health Care Application #33215

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

longmd
Copy link
Contributor

@longmd longmd commented Nov 25, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This PR isolates updates spec coverage for various form pages, fields and review components. No updates were made to the methods themselves, just the spec coverage.

Related issue(s)

department-of-veterans-affairs/va.gov-team#60897

Acceptance criteria

  • Spec coverage meets or exceeds allowable coverage numbers

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Screenshot of the developed feature is added

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

Copy link
Contributor

@coope93 coope93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but looks great! Nice work on these. I'm really liking the subject pattern in these specs; it makes it way more readable to me.

@longmd longmd merged commit acb6820 into main Nov 27, 2024
83 of 85 checks passed
@longmd longmd deleted the longmd-60897-hca-component-spec-coverage branch November 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants