Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-20329 Add new Teamsites for injected assets #34203

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

randimays
Copy link
Contributor

Summary

Add new TeamSites domains to enable injected header/footer to appear. We have the cookieOnly value as a temporary testing flag (the injected H/F will only show when the correct cookie is passed to the browser). Once we have confirmed everything is working as expected with the cookie on, we can make code changes to remove that.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#20329

Testing done & screenshots

Confirmed the header and footer shows up on all 3 new domains (with and without the www appended):

https://www.mentalhealth.va.gov/

Screenshot 2025-01-22 at 1 44 55 PM Screenshot 2025-01-22 at 1 49 27 PM

https://mentalhealth.va.gov/

Screenshot 2025-01-22 at 1 44 45 PM Screenshot 2025-01-22 at 1 49 17 PM

https://www.mirecc.va.gov/

Screenshot 2025-01-22 at 1 44 03 PM Screenshot 2025-01-22 at 1 48 37 PM

https://mirecc.va.gov/

Screenshot 2025-01-22 at 1 44 13 PM Screenshot 2025-01-22 at 1 48 27 PM

https://www.ptsd.va.gov/

Screenshot 2025-01-22 at 1 43 47 PM Screenshot 2025-01-22 at 1 48 59 PM

https://ptsd.va.gov/

Screenshot 2025-01-22 at 1 43 29 PM Screenshot 2025-01-22 at 1 48 49 PM

@randimays randimays requested review from a team as code owners January 22, 2025 19:53
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jilladams jilladams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked for www vs. non-www:

@jilladams
Copy link
Contributor

I saw you already handled the 3rd one, so lemme know if I'm missing something with those 2.

Copy link
Contributor

@jilladams jilladams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh - i see over those 2 are already handled. 🤦‍♀️

@randimays randimays merged commit f366c51 into main Jan 22, 2025
68 checks passed
@randimays randimays deleted the 20329-add-teamsites branch January 22, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants