-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-20329 Add new Teamsites for injected assets #34203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked for www vs. non-www:
- www.mentalhealth.va.gov resolves / doesn't forward to non-www so will need to be added
- www.ptsd.va.gov same
I saw you already handled the 3rd one, so lemme know if I'm missing something with those 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh - i see over those 2 are already handled. 🤦♀️
Summary
Add new TeamSites domains to enable injected header/footer to appear. We have the
cookieOnly
value as a temporary testing flag (the injected H/F will only show when the correct cookie is passed to the browser). Once we have confirmed everything is working as expected with the cookie on, we can make code changes to remove that.Related issue(s)
department-of-veterans-affairs/va.gov-cms#20329
Testing done & screenshots
Confirmed the header and footer shows up on all 3 new domains (with and without the
www
appended):https://www.mentalhealth.va.gov/
https://mentalhealth.va.gov/
https://www.mirecc.va.gov/
https://mirecc.va.gov/
https://www.ptsd.va.gov/
https://ptsd.va.gov/