Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#vebt-848 #comment Added step 3 submission instructions for 22-10215 #34232

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

govcioChad
Copy link
Contributor

@govcioChad govcioChad commented Jan 23, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

- (Summarize the changes that have been made to the platform)

  • Created Step 3 submission instructions page of 22-10215 form.

- (If bug, how to reproduce)

  • N/A

- (What is the solution, why is this the solution)

  • Added page before review page

- (Which team do you work for, does your team own the maintenance of this component?)

  • GovCIO , we are the code owners
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Jira -> https://jira.devops.va.gov/browse/VEBT-848

As a...

VEBT Developer

I want…

To build STEP 3 of the 22-10215

So that…

Form development can be completed

Acceptance Criteria

Bullet points are only for reference to dev/tester and not for final render of form.

Header -> How to submit your form

Please note: This form does not submit automatically. After you review your information, download your completed VA Form 22-10215. Then, upload it manually through the VA Education Portal to complete the submission process

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

image

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@govcioChad govcioChad merged commit 9e1b441 into main Jan 28, 2025
86 checks passed
@govcioChad govcioChad deleted the vebt-848 branch January 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants