Disable Prefill for the My VA Review Contact Information form

[nicksayre]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

• No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
• Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

1. Deleting a folder:

   1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
   2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here

2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

• No
• Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

• Changes a config property on the My VA Review Contact Information form, and removes the ID of the same form from a file. Both of these changes are a attempt to prevent our form from appearing on the list of draft forms on the My VA page.
• prefillEnabled is not documented thoroughly enough for me to be confident that this change will work. This is an experiment.
• I work for VA IIR and we own this form.

Related issue(s)

VA IIR issue 1385

Testing done

If this is working as intended, we will see in staging that a draft form is not created after one or more changes have been made using our form.

Screenshots

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[adamwhitlock1]

The only thing that might trip this up is that if your form did have an 'in progress draft' of the form that was saved while you were testing in staging, then it could blow up myVA, but since it hasn't been launched in prod this wouldn't be an issue and should be fine.

If you do find that a certain test user has your form listed as having a current draft for it and we need to remove that draft let me know and I'm sure we can figure out a a way to fix that.

[adamwhitlock1]

you are going to want to remove the whole object in this array and not just the id.

[adamwhitlock1]

remove that whole object from that constant and then you should be good to go

[khenson-oddball]

LGTM

[adamwhitlock1]

I see some proof of veteran status changes also got added to this PR, was that something you meant to do @nicksayre ?

[nicksayre]

I see some proof of veteran status changes also got added to this PR, was that something you meant to do @nicksayre ?

Yes, when I removed the reference to our app in src/platform/forms/constants.js I was seeing a React error when visiting the Military Information page. vetStatusEligibility.message wasn’t being found. When I applied a fix to the proof of veteran status components, the error was resolved.