-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mhv 65761 reroute unauthorized users #34303
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reposting my feedback from Slack so it doesn't get lost: there are a few approaches to "guarding" access in place, and one like useMyHealthAccessGuard does a minimal check, on the client side. I think we'd benefit from calling out the vets-api service/policy checks in this new component, so perhaps a name like MHVServiceRequiredGuard
would be clearer.
Also no wondering if we should remove useMyHealthAccessGuard
if all MHV teams are using vets-api service/policy checks now…
I'd be open to this or a follow-up PR removing the useMyHealthAccessGuard
code, as that seems obsolete.
2b9fd62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for taking my naming concern seriously. The MhvServiceRequiredGuard
looks good to me, and easy to check using the "acceleratedCernerUser" mock user, since they don't have SM as a service.
This looks good to me!
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
MHV-65761 - Handle rerouting to /my-health for unauthorized users
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?