Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 Appointment list refactor to reduce screenreader verbosity #34433

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jan 31, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Remove redundant roles in AppointmentRow and AppointmentColumn to reduce verbosity when navigating via screen readers like Voice Over
  • Appointments (VAOS) Team
  • This is not behind a Flipper

Related issue(s)

Testing done

  • Tested appointment lists locally with various screen widths
  • Tested locally with Voice Over

Screenshots

These screenshots are expected to be identical before and after this change since the visible UI should remain unchanged.

Before After
Mobile (Narrow) image image
Mobile (Wide) image image
Desktop image image

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@JunTaoLuo JunTaoLuo force-pushed the jtluo/appointment-list-grid-refactor branch from f867e55 to 2df0884 Compare February 4, 2025 16:44
@JunTaoLuo JunTaoLuo changed the title WIP DO NOT MERGE - Testing appointment list refactor 508 Appointment list refactor to reduce screenreader verbosity Feb 4, 2025
@JunTaoLuo JunTaoLuo marked this pull request as ready for review February 4, 2025 16:54
@JunTaoLuo JunTaoLuo requested review from a team as code owners February 4, 2025 16:54
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jenniemc jenniemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JunTaoLuo JunTaoLuo merged commit 2447013 into main Feb 6, 2025
85 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/appointment-list-grid-refactor branch February 6, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants