Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Staged Continuous Deployment #34442

Merged
merged 11 commits into from
Feb 3, 2025
Merged

Implement Staged Continuous Deployment #34442

merged 11 commits into from
Feb 3, 2025

Conversation

CBonade
Copy link
Contributor

@CBonade CBonade commented Jan 31, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Implements pause in CD pipeline that requires an approval from authorized approvers.
  • Adds correct data points to be passed from CI workflow to production deploy workflow.

Testing done

  • Tested with duplicate workflow and manual inputs.

@CBonade CBonade changed the title Set up test trigger for workflow Implement Staged Continuous Deployment Feb 3, 2025
@CBonade CBonade marked this pull request as ready for review February 3, 2025 19:19
@CBonade CBonade requested a review from a team as a code owner February 3, 2025 19:19
Copy link
Contributor

@IGallupSoCo IGallupSoCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBonade CBonade merged commit 99d05e3 into main Feb 3, 2025
62 checks passed
@CBonade CBonade deleted the staged-cd-staging-pr branch February 3, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants