Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update component-library to v49.0.0" #34451

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

micahchiang
Copy link
Contributor

Reverts #34404

Reverting because we're seeing some unexpected regressions in radio buttons and checkboxes.

Andrew565
Andrew565 previously approved these changes Jan 31, 2025
Signed-off-by: Micah Chiang <[email protected]>
Signed-off-by: Micah Chiang <[email protected]>
@@ -3,7 +3,7 @@ import { ROUTES } from '../../../constants';
import { SHORT_NAME_MAP } from '../../../constants/question-data-map';

describe('Review edit flows', () => {
it('Back and Continue with no answer change returns to review screen', () => {
it.skip('Back and Continue with no answer change returns to review screen', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I need to skip this test for the time being. I've tried to reproduce this failure locally and haven't been able to. In the video asset produced by CI this test seems to skip the failure to exhaust URL completely and go to the prior service URL, or at least, the order seems to be incorrect. Locally, the order seems fine, and the test passes without a hitch.

@@ -40,7 +40,7 @@ import { getTypeOfCareById } from '../../../../utils/appointment';
const typeOfCareId = getTypeOfCareById(OPHTHALMOLOGY_ID).idV2;
const { cceType } = getTypeOfCareById(OPHTHALMOLOGY_ID);

describe('VAOS request schedule flow - Audiology', () => {
describe.skip('VAOS request schedule flow - Audiology', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I need to skip this test for the time being. I've tried to reproduce the failure locally but the tests pass without a problem.

@@ -38,7 +38,7 @@ import { getTypeOfCareById } from '../../../../utils/appointment';
const { cceType } = getTypeOfCareById(PRIMARY_CARE);
const typeOfCareId = getTypeOfCareById(PRIMARY_CARE).idV2;

describe('VAOS direct schedule flow - Primary care', () => {
describe.skip('VAOS direct schedule flow - Primary care', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Apologies, I need to skip this test for the time being. I've tried to reproduce the failure locally but the tests pass without a problem.

@micahchiang micahchiang merged commit 3f28640 into main Feb 1, 2025
83 checks passed
@micahchiang micahchiang deleted the revert-34404-component-library-release-v49.0.0 branch February 1, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants