Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 Support #10829

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Python 3.13 Support #10829

wants to merge 5 commits into from

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Oct 22, 2024

What are you trying to accomplish?

Add Python 3.13 support and bump pyenv version.

Resolves #10828

I tried to copy related changes from #8732 but I feel like I missed if there is anything special required for 3.13 . Please feel free to direct me whatever needs to be added or fixed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@ulgens ulgens requested a review from a team as a code owner October 22, 2024 06:46
@ulgens ulgens changed the title Python 3.13 Python 3.13 Support Oct 22, 2024
@ulgens ulgens force-pushed the python_3.13 branch 2 times, most recently from af386af to 7151103 Compare October 31, 2024 17:14
@ulgens
Copy link
Contributor Author

ulgens commented Nov 12, 2024

@jurre @landongrindheim @deivid-rodriguez Hey all 👋🏻 I want to finish this piece of work and push it forward but I don't understand why ci (python, python_slow, pip) pipeline fails.

@edgarrmondragon
Copy link

@ulgens I think it's trying to install a Pandas version that fails to build on Python 3.13. Might be worth bumping this

@ulgens
Copy link
Contributor Author

ulgens commented Nov 13, 2024

@edgarrmondragon Is there any difference in packages between python and python_slow tests?

@ulgens
Copy link
Contributor Author

ulgens commented Nov 13, 2024

It seems the issue is librosa/librosa#1883 and it's waiting for a new release of numba. Numba release is blocked by https://github.com/numba/numba/milestone/81 .

@feelepxyz Is there a specific reason to have librosa in python/spec/fixtures/projects/unresolvable/requirements.in? Can we remove or replace it?

@zhu0629
Copy link

zhu0629 commented Nov 28, 2024

Any update on this?

@edgarrmondragon
Copy link

Any update on this?

AFAICT, the dependabot team is swamped so it's probably take them some time to review this as I don't think it's really a priority or a blocker for a lot of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13 Support
3 participants