Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate credentials store to electron-store #27

Merged
merged 7 commits into from
Oct 26, 2023
Merged

migrate credentials store to electron-store #27

merged 7 commits into from
Oct 26, 2023
+166 −16

Conversation

98sean98
Copy link
Contributor

  • add electron and electron-store packages
  • use electron safeStorage and Store APIs to store / retrieve credentials
  • store token as plain text
  • remove electron package

@98sean98 98sean98 added the bug Something isn't working label Oct 24, 2023
@98sean98 98sean98 self-assigned this Oct 24, 2023
@98sean98 98sean98 requested a review from utkarsh867 October 24, 2023 06:55
@98sean98 98sean98 linked an issue Oct 24, 2023 that may be closed by this pull request
fail to activate extension in macOS 13.6, 14 and above #26
Closed
@98sean98 98sean98 marked this pull request as ready for review October 24, 2023 07:33
@98sean98 98sean98 merged commit 12ba900 into main Oct 26, 2023
1 check passed
@98sean98 98sean98 deleted the migrate/credentials branch October 26, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsh867 utkarsh867 Awaiting requested review from utkarsh867

Assignees

@98sean98 98sean98

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to activate extension in macOS 13.6, 14 and above
1 participant
@98sean98