Skip to content

Commit

Permalink
Revert "feat(registry): remove stdio tunnel for fast --load"
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobwgillespie authored Sep 11, 2023
1 parent 34e04fb commit e7155d6
Show file tree
Hide file tree
Showing 15 changed files with 686 additions and 1,001 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RUN \

FROM --platform=$TARGETPLATFORM ubuntu:20.04

RUN apt-get update && apt-get install -y ca-certificates curl && rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get install -y ca-certificates && rm -rf /var/lib/apt/lists/*
COPY entrypoint.sh /usr/bin/entrypoint.sh
COPY --from=build /out/depot /usr/bin/depot
COPY --from=build /out/buildkitd /usr/bin/buildkitd
Expand Down
2 changes: 1 addition & 1 deletion examples/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require (
github.com/containerd/containerd v1.6.20 // indirect
github.com/containerd/continuity v0.4.1 // indirect
github.com/containerd/ttrpc v1.2.2 // indirect
github.com/containerd/typeurl v1.0.2
github.com/containerd/typeurl v1.0.3-0.20220422153119-7f6e6d160d67 // indirect
github.com/docker/distribution v2.8.1+incompatible // indirect
github.com/fatih/color v1.13.0 // indirect
github.com/go-logr/logr v1.2.3 // indirect
Expand Down
11 changes: 1 addition & 10 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ require (
require (
github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
github.com/Microsoft/go-winio v0.6.0 // indirect
github.com/Microsoft/hcsshim v0.9.8 // indirect
github.com/agext/levenshtein v1.2.3 // indirect
github.com/agl/ed25519 v0.0.0-20170116200512-5312a6153412 // indirect
github.com/apparentlymart/go-cidr v1.0.1 // indirect
Expand All @@ -72,17 +71,14 @@ require (
github.com/cenkalti/backoff/v4 v4.2.0 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
github.com/compose-spec/compose-go v1.6.0 // indirect
github.com/containerd/cgroups v1.0.4 // indirect
github.com/containerd/continuity v0.3.0 // indirect
github.com/containerd/fifo v1.0.0 // indirect
github.com/containerd/ttrpc v1.1.1 // indirect
github.com/containerd/typeurl v1.0.2 // indirect
github.com/containerd/typeurl v1.0.3-0.20220422153119-7f6e6d160d67 // indirect
github.com/creack/pty v1.1.12 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/distribution/distribution/v3 v3.0.0-20220725133111-4bf3547399eb // indirect
github.com/docker/docker-credential-helpers v0.7.0 // indirect
github.com/docker/go v1.5.1-1.0.20160303222718-d30aec9fd63c // indirect
github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c // indirect
github.com/docker/go-metrics v0.0.1 // indirect
github.com/fatih/color v1.13.0 // indirect
github.com/felixge/httpsnoop v1.0.3 // indirect
Expand All @@ -92,7 +88,6 @@ require (
github.com/go-logr/stdr v1.2.2 // indirect
github.com/gofrs/flock v0.8.1 // indirect
github.com/gogo/googleapis v1.4.1 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/google/go-cmp v0.5.9 // indirect
github.com/google/gofuzz v1.2.0 // indirect
Expand Down Expand Up @@ -133,9 +128,6 @@ require (
github.com/muesli/cancelreader v0.2.2 // indirect
github.com/muesli/reflow v0.3.0 // indirect
github.com/muesli/termenv v0.13.0 // indirect
github.com/opencontainers/runc v1.1.5 // indirect
github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417 // indirect
github.com/opencontainers/selinux v1.10.2 // indirect
github.com/pelletier/go-toml v1.9.5 // indirect
github.com/pelletier/go-toml/v2 v2.0.5 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
Expand All @@ -159,7 +151,6 @@ require (
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect
github.com/xeipuuv/gojsonschema v1.2.0 // indirect
github.com/zclconf/go-cty v1.10.0 // indirect
go.opencensus.io v0.23.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.29.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace v0.29.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.29.0 // indirect
Expand Down
504 changes: 2 additions & 502 deletions go.sum

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions pkg/buildx/commands/bake.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ func RunBake(dockerCli command.Cli, in BakeOptions, validator BakeValidator) (er
buildOpts,
load.DepotLoadOptions{
UseLocalRegistry: in.DepotOptions.useLocalRegistry,
ProxyImage: in.DepotOptions.proxyImage,
Project: in.DepotOptions.project,
BuildID: in.DepotOptions.buildID,
IsBake: true,
Expand Down
1 change: 1 addition & 0 deletions pkg/buildx/commands/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ func buildTargets(ctx context.Context, dockerCli command.Cli, nodes []builder.No
opts,
load.DepotLoadOptions{
UseLocalRegistry: depotOpts.useLocalRegistry,
ProxyImage: depotOpts.proxyImage,
Project: depotOpts.project,
BuildID: depotOpts.buildID,
IsBake: false,
Expand Down
10 changes: 0 additions & 10 deletions pkg/buildxdriver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,6 @@ func (d *Driver) Bootstrap(ctx context.Context, reporter progress.Logger) error
_, err = d.buildkit.Connect(ctx)
finishLog(err)

// Store the machine connection details in the driver config so they can be
// accessed by clients that need to create new connections to the machine.
// This was done because the buildkit client doesn't expose the connection.
// This was added originally for the registry proxy.
d.cfg.DriverOpts["addr"] = d.buildkit.Addr
d.cfg.DriverOpts["serverName"] = d.buildkit.ServerName
d.cfg.DriverOpts["caCert"] = d.buildkit.CACert
d.cfg.DriverOpts["key"] = d.buildkit.Key
d.cfg.DriverOpts["cert"] = d.buildkit.Cert

return err
}

Expand Down
Loading

0 comments on commit e7155d6

Please sign in to comment.