Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-165] hotfix: 바뀐 배너 정책에 맞게 배너 API 모킹 변경 #125

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Kwon770
Copy link
Collaborator

@Kwon770 Kwon770 commented Jan 24, 2024

❓ 기능 추가 배경


배너 정책이 바뀜에 따라 서버 드리븐하게 UI를 정하게 되었습니다. 그에 맞게 API Spec과 모킹을 변경합니다.

➕ 추가/변경된 기능


  • BannerResponse 리펙토링
  • API 모킹부 리펙토링

🥺 리뷰어에게 하고싶은 말


파이팅..

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-165

@Kwon770 Kwon770 added 🔥 HOTFIX 긴급 픽스 ♻️ REFACTORING 리팩토링 labels Jan 24, 2024
@Kwon770 Kwon770 requested a review from CChuYong January 24, 2024 15:34
@Kwon770 Kwon770 self-assigned this Jan 24, 2024
@github-actions github-actions bot changed the title 바뀐 배너 정책에 맞게 배너 API 모킹 변경 [OING-165] 바뀐 배너 정책에 맞게 배너 API 모킹 변경 Jan 24, 2024
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

37 files  37 suites   7s ⏱️
85 tests 85 ✅ 0 💤 0 ❌
86 runs  86 ✅ 0 💤 0 ❌

Results for commit 45eeb20.

Copy link

Code Coverage

File Coverage [97.8%] 🍏
BannerResponse.java 100% 🍏
BannerImageType.java 100% 🍏
CalendarController.java 96.89% 🍏
Total Project Coverage 52.56% 🍏

@CChuYong CChuYong merged commit b1fa284 into dev Jan 24, 2024
4 checks passed
@CChuYong CChuYong deleted the feature/OING-165 branch January 24, 2024 16:28
@Ji-soo708 Ji-soo708 changed the title [OING-165] 바뀐 배너 정책에 맞게 배너 API 모킹 변경 [OING-165] hotfix: 바뀐 배너 정책에 맞게 배너 API 모킹 변경 Jan 24, 2024
@Kwon770 Kwon770 restored the feature/OING-165 branch January 30, 2024 13:16
@CChuYong CChuYong deleted the feature/OING-165 branch February 11, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 HOTFIX 긴급 픽스 ♻️ REFACTORING 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants