Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-174] feat: 사용자 그룹 가입 일자 필드 추가 #127

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

CChuYong
Copy link
Member

@CChuYong CChuYong commented Jan 28, 2024

❓ 기능 추가 배경


image

➕ 추가/변경된 기능


  • 가입 일자 필드 추가 및 api 필드 추가
  • 에 따른 테스트 수리

🥺 리뷰어에게 하고싶은 말


다들 몸조심하세요

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-174

@CChuYong CChuYong added the ✨ FEATURE 기능 추가 label Jan 28, 2024
@CChuYong CChuYong requested review from Kwon770 and Ji-soo708 January 28, 2024 09:28
@CChuYong CChuYong self-assigned this Jan 28, 2024
Copy link

github-actions bot commented Jan 28, 2024

Test Results

15 tests   15 ✅  0s ⏱️
 8 suites   0 💤
 8 files     0 ❌

Results for commit 994d464.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@Ji-soo708 Ji-soo708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@Ji-soo708 Ji-soo708 merged commit f881b1a into dev Jan 28, 2024
3 of 4 checks passed
@Ji-soo708 Ji-soo708 deleted the feature/OING-174 branch January 28, 2024 10:44
CChuYong added a commit that referenced this pull request Jan 31, 2024
* feat: add familyJoinAt column

* test: fix member related test issues

* feat: add migration sql script
CChuYong added a commit that referenced this pull request Jan 31, 2024
* feat: add familyJoinAt column

* test: fix member related test issues

* feat: add migration sql script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEATURE 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants