Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-182] refactor: 자동 주입되는 familyId 파라미터 숨김 처리 #131

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Jan 30, 2024

❓ 기능 추가 배경


스프링 내에서 자동 주입되어 프론트에서 보낼 필요가 없는 familyId 파라미터를 스웨거에서 숨김처리했습니다.

➕ 추가/변경된 기능


  • 자동 주입되는 familyId 파라미터 숨김 처리

🥺 리뷰어에게 하고싶은 말


리뷰 부탁드려요~

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-182

@Ji-soo708 Ji-soo708 added the 📄 DOCS 문서화 label Jan 30, 2024
@Ji-soo708 Ji-soo708 self-assigned this Jan 30, 2024
Copy link

Test Results

15 tests   15 ✅  0s ⏱️
 8 suites   0 💤
 8 files     0 ❌

Results for commit de06343.

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ji-soo708 Ji-soo708 requested review from Kwon770 and CChuYong January 30, 2024 16:32
@Ji-soo708 Ji-soo708 changed the title [OING-182] docs: 자동 주입되는 familyId 파라미터 숨김 처리 [OING-182] refactor: 자동 주입되는 familyId 파라미터 숨김 처리 Jan 30, 2024
@Ji-soo708 Ji-soo708 added ♻️ REFACTORING 리팩토링 and removed 📄 DOCS 문서화 labels Jan 30, 2024
Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접 요청한 부분이네여. LGTM~

@Kwon770 Kwon770 merged commit b11924f into dev Jan 30, 2024
3 of 4 checks passed
@Kwon770 Kwon770 deleted the feature/OING-182 branch January 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants