[OING-173] feat: MVP 2차 추억 캘린더 배너 구현 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oadedDays, allFamilyMembersUploadedStreaks) and Impl getBanner API with a lot of comments
… feature/OING-173
github-actions
bot
changed the title
Test Results39 files 39 suites 8s ⏱️ For more details on these failures, see this check. Results for commit 7184073. ♻️ This comment has been updated with latest results. |
CChuYong
approved these changes
Jan 31, 2024
CChuYong
requested changes
Jan 31, 2024
gateway/src/main/java/com/oing/controller/CalendarController.java
Outdated
Show resolved
Hide resolved
CChuYong
approved these changes
Jan 31, 2024
Ji-soo708
reviewed
Jan 31, 2024
| @@ -101,10 +108,14 @@ public Page<FamilyMemberProfileResponse> findFamilyMembersProfilesByFamilyId( | |||
| return new PageImpl<>(familyMemberProfiles, memberPage.getPageable(), memberPage.getTotalElements()); | |||
| } | |||
|
|
|||
| public long countFamilyMembersByFamilyIdBefore(String familyId, LocalDate date) { | |||
| return memberRepository.countByFamilyIdAndFamilyJoinAtBefore(familyId, date.atStartOfDay()); | |||
There was a problem hiding this comment.
혹시 1월 1일에 가족 전체 멤버가 2명인 가족이 모두 포스트를 올렸는데 1월 2일에 새 멤버가 추가되어서 전체 멤버가 3명이 되면 1월 1일에 올린 포스트는 가족 모두가 올린 날에 집계가 되나요??
There was a problem hiding this comment.
아닙니다. 글이 업로드 된 그 당시의 날에 존재했던 멤버가 전부 올렸는지가 기준입니다. 1월1일에는 2개의 사진이 올라와야만 하고, 1월2일에는 3개의 사진이 올라와야 전부 올라온 날인 것 입니다.
post/src/main/java/com/oing/controller/MemberPostController.java
Outdated
Show resolved
Hide resolved
…amic field of getBanner API to fix wrongly selected period
|
CChuYong
pushed a commit
that referenced
this pull request
Jan 31, 2024
* feat: Add familyScore definition * feat: Add JpaEntity and SpringEvent to add score per user activity * feat: Add the events to substract score per canceled user activity * fix: Change FamilyScoreEventListener annotation to fix not committed score event * feat: Impl the code to calculate the familyTopPercentage in getBanner API * feat: Impl the code to count family activity in getBanner API * feat: Add counting code to banners dynamic fields(allFamilyMembersUploadedDays, allFamilyMembersUploadedStreaks) and Impl getBanner API with a lot of comments * fix: Fix broken test code with changed Member entity * fix: Handle divide by zero error from calculateFamilyTopPercentile method * fix: Replace inclusiveToday as endDate from the code to calculate dynamic field of getBanner API to fix wrongly selected period * chore: Clear the commenting at redis cache annotation in MemberPostController
CChuYong
pushed a commit
that referenced
this pull request
Jan 31, 2024
* feat: Add familyScore definition * feat: Add JpaEntity and SpringEvent to add score per user activity * feat: Add the events to substract score per canceled user activity * fix: Change FamilyScoreEventListener annotation to fix not committed score event * feat: Impl the code to calculate the familyTopPercentage in getBanner API * feat: Impl the code to count family activity in getBanner API * feat: Add counting code to banners dynamic fields(allFamilyMembersUploadedDays, allFamilyMembersUploadedStreaks) and Impl getBanner API with a lot of comments * fix: Fix broken test code with changed Member entity * fix: Handle divide by zero error from calculateFamilyTopPercentile method * fix: Replace inclusiveToday as endDate from the code to calculate dynamic field of getBanner API to fix wrongly selected period * chore: Clear the commenting at redis cache annotation in MemberPostController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
�MVP 2차 기획으로 변경된 추억 캘린더의 배너 전체 기능을 구현하였습니다. 최적화는 전혀 적용되지 않고 구현에만 집중한 버전이므로, 차후 작업이 필요합니다.
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
🚨 전반적인 비즈니스 로직을 추가 및 변경하는 기능이 였으나 시간이 모자라여 테스트 코드 작성과 디버깅이 미흡하였습니다. 세밀하게 리뷰해주시면 감사하겠습니다 😭 🚨
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-173