Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-184] chore: MicroMeter Prometheus 구현체 추가 #136

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

Kwon770
Copy link
Collaborator

@Kwon770 Kwon770 commented Jan 31, 2024

❓ 기능 추가 배경


프로메테우스 & 그라파나 중계 서버 구축을 위해 MicroMeter Prometheus 구현체를 추가합니다.

➕ 추가/변경된 기능


  • MicroMeter Prometheus Dependency 추가
  • Actuator, Prometheus의 management endpoints - health, info, prometheus 허용

🥺 리뷰어에게 하고싶은 말


�긴급히!!

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-184

@Kwon770 Kwon770 added 🔥 HOTFIX 긴급 픽스 ⚙️ CHORE config, workflow.yml labels Jan 31, 2024
@Kwon770 Kwon770 requested a review from CChuYong January 31, 2024 12:10
@Kwon770 Kwon770 self-assigned this Jan 31, 2024
@github-actions github-actions bot changed the title chore: MicroMeter Prometheus 구현체 추가 [OING-184] chore: MicroMeter Prometheus 구현체 추가 Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

Test Results

39 files  39 suites   7s ⏱️
91 tests 90 ✅ 0 💤 1 ❌
92 runs  91 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 731df92.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ji-soo708 Ji-soo708 self-requested a review January 31, 2024 13:14
Copy link
Member

@Ji-soo708 Ji-soo708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@Kwon770 Kwon770 merged commit 4c79f90 into dev Jan 31, 2024
2 of 4 checks passed
@Kwon770 Kwon770 deleted the feature/OING-184 branch January 31, 2024 13:16
Ji-soo708 pushed a commit that referenced this pull request Feb 1, 2024
* chore: Add micrometer prometheus and configs

* chore: Remove metrics endpoints from application.yaml for actuaor

* fix: Fix broken CalendarApiTest by making optimizing query public
CChuYong pushed a commit that referenced this pull request Feb 1, 2024
* chore: Add micrometer prometheus and configs

* chore: Remove metrics endpoints from application.yaml for actuaor

* fix: Fix broken CalendarApiTest by making optimizing query public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ CHORE config, workflow.yml 🔥 HOTFIX 긴급 픽스
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants