Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-191] hotfix: 회원가입 시에 프로필 이미지 키 추출하는 로직 수정 #149

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Feb 5, 2024

❓ 기능 추가 배경


현재 회원가입 시에 프로필 이미지 키를 추출하는 로직이 제대로 동작하지 않아 로직 수정했습니다.

➕ 추가/변경된 기능


  • 회원가입 시에 프로필 이미지 키 추출하는 로직 수정

🥺 리뷰어에게 하고싶은 말


잠깐 홀드시키겠습니다.

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-191

@Ji-soo708 Ji-soo708 self-assigned this Feb 5, 2024
@Ji-soo708 Ji-soo708 added 🔥 HOTFIX 긴급 픽스 🐛 BUG 버그 labels Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Test Results

39 files  39 suites   8s ⏱️
91 tests 90 ✅ 0 💤 1 ❌
92 runs  91 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 900a8a5.

♻️ This comment has been updated with latest results.

@Ji-soo708 Ji-soo708 added the 🔒 HOLD 머지하지 말고 잠시 홀드 label Feb 5, 2024
@Ji-soo708 Ji-soo708 removed the 🔒 HOLD 머지하지 말고 잠시 홀드 label Feb 5, 2024
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ji-soo708 Ji-soo708 changed the title [OING-191] hotfix: 회원가입 시에 프로필 이미지 키 추출하는 로직 위치 이동 [OING-191] hotfix: 회원가입 시에 프로필 이미지 키 추출하는 로직 수정 Feb 6, 2024
Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순히 null 체크 위치만 바뀌었는데, 문제가 해결된 것일까요?

Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ji-soo708 Ji-soo708 merged commit 408e7c9 into dev Feb 7, 2024
2 of 4 checks passed
@Ji-soo708 Ji-soo708 deleted the feature/OING-191 branch February 7, 2024 07:04
CChuYong pushed a commit that referenced this pull request Feb 10, 2024
* fix: move setProfileImgKey logic to AuthController

* style: uncomment class file

* fix: fix profileImgKey logic in createNewMember
CChuYong pushed a commit that referenced this pull request Feb 11, 2024
* fix: move setProfileImgKey logic to AuthController

* style: uncomment class file

* fix: fix profileImgKey logic in createNewMember
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG 버그 🔥 HOTFIX 긴급 픽스
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants