-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OING-191] hotfix: 회원가입 시에 프로필 이미지 키 추출하는 로직 수정 #149
Conversation
Test Results39 files 39 suites 8s ⏱️ For more details on these failures, see this check. Results for commit 900a8a5. ♻️ This comment has been updated with latest results. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순히 null 체크 위치만 바뀌었는데, 문제가 해결된 것일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix: move setProfileImgKey logic to AuthController * style: uncomment class file * fix: fix profileImgKey logic in createNewMember
* fix: move setProfileImgKey logic to AuthController * style: uncomment class file * fix: fix profileImgKey logic in createNewMember
❓ 기능 추가 배경
현재 회원가입 시에 프로필 이미지 키를 추출하는 로직이 제대로 동작하지 않아 로직 수정했습니다.
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
잠깐 홀드시키겠습니다.
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-191