[OING-193] feat: 회원 리얼이모지 familyId 컬럼 추가 및 로직 수정 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ji-soo708
changed the title
Ji-soo708
commented
Feb 7, 2024
| @@ -44,10 +44,6 @@ public class Member extends DeletableBaseAuditEntity { | |||
| private LocalDateTime familyJoinAt; | |||
|
|
|||
|
|
|||
| public void setProfileImgKey(String profileImgKey) { | |||
|
Test Results39 files 39 suites 8s ⏱️ Results for commit fc8b207. |
Code Coverage
|
CChuYong
pushed a commit
that referenced
this pull request
Feb 10, 2024
* feature: add familyId column to MemberRealEmoji * feature: add familyId parameter to MemberRealEmoji logic * refactor: refact MemberRealEmojiApi logic * test: fix test error due to added familyId * style: delete unused method * test: fix MemberPostRealEmoji test due to added familyId parameter * test: add getMemberRealEmojis when member quit group
CChuYong
pushed a commit
that referenced
this pull request
Feb 11, 2024
* feature: add familyId column to MemberRealEmoji * feature: add familyId parameter to MemberRealEmoji logic * refactor: refact MemberRealEmojiApi logic * test: fix test error due to added familyId * style: delete unused method * test: fix MemberPostRealEmoji test due to added familyId parameter * test: add getMemberRealEmojis when member quit group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
회원이 그룹 탈퇴를 했을 때를 대비하여, 회원 리얼이모지 테이블에 familyId를 추가하고 로직을 수정했습니다.
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
로컬에서 API 호출하면서 회원의 가족이 바뀌어도 적절히 대응함을 확인했는데 리얼이모지 안에서 추가적으로 familyId를 고려해야 하는 기능이 있다면 알려주세요
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-193