Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-335] fix: 가족구성원 랭킹 API의 생존신고 수가 미션 수를 포함하는 현상 해결 #257

Merged
merged 2 commits into from
May 18, 2024

Conversation

Kwon770
Copy link
Collaborator

@Kwon770 Kwon770 commented May 17, 2024

❓ 기능 추가 배경


3.0 QA 에서 가족구성원 랭킹 API의 생존신고 수가 미션 수를 포함하는 현상이 리포트되었습니다.

버그를 고치기 위해 쿼리를 수정하던 중 지난 번에 생성한 Post CreatedAt 인덱스를 탈 수 있도록 비교 쿼리를 리팩토링했습니다.

➕ 추가/변경된 기능


  • 리포트 된 버그를 고치기 위해 PostType.Survival 비교 연산자 추가
  • CreatedAt에서 year(), month()를 별도로 추출해서 equals 비교하는 연산자에서 인덱스를 타기 위해 between 연산자로 리팩토링

🥺 리뷰어에게 하고싶은 말


파이팅

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-335

@Kwon770 Kwon770 self-assigned this May 17, 2024
@github-actions github-actions bot changed the title fix: 가족구성원 랭킹 API의 생존신고 수가 미션 수를 포함하는 현상 해결 [OING-335] fix: 가족구성원 랭킹 API의 생존신고 수가 미션 수를 포함하는 현상 해결 May 17, 2024
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

 51 files   51 suites   12s ⏱️
141 tests 141 ✅ 0 💤 0 ❌
142 runs  142 ✅ 0 💤 0 ❌

Results for commit 73f3d17.

Copy link

Code Coverage

File Coverage [77.05%]
PostRepositoryCustomImpl.java 80.15% 🍏
PostController.java 79.38%
PostService.java 71.56%
Total Project Coverage 52% 🍏

Copy link
Member

@Ji-soo708 Ji-soo708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다~

@Kwon770 Kwon770 merged commit bcd8825 into dev May 18, 2024
4 checks passed
@Kwon770 Kwon770 deleted the feature/OING-335 branch May 18, 2024 02:04
Kwon770 added a commit that referenced this pull request May 30, 2024
* fix: Fix wrongly written post counting query that count survival and mission post both

* refactor: Refactor the query to compare createdAt of Post by eqauals with year and month to between for index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants