[OING-336] feat: 푸쉬 알림 메세지 변경 및 미션 업로드 시 노티 발송 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 51 files 51 suites 12s ⏱️ Results for commit 1fb81ef. ♻️ This comment has been updated with latest results. |
Code Coverage
|
Ji-soo708
reviewed
May 27, 2024
| .setAndroidConfig(FCMNotificationUtil.buildAndroidConfig()) | ||
| .build(); | ||
| fcmNotificationService.sendMulticastMessage(missionUnlockedMessage); | ||
| } |
There was a problem hiding this comment.
onPostCreatedEvent에서 사용자가 글을 작성했을 때, 가족이 미션 키를 획득했을 때 두 가지 경우에 대해 모두 처리하고 있는데, 이 두 가지 경우를 각 메서드로 분리해서 책임을 명확히 하면 더 좋을 거 같아요!
|
Kwon770
pushed a commit
that referenced
this pull request
May 30, 2024
* feat: update pick notification * feat: send notification if mission unlocked * feat: send survival noti only on survival post * refactor: move mission message to another method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
�- 푸쉬 알림 컨텐츠 변경 및 경로 추가
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
백엔드 PR 엄청 오랜만이네요 ㄷㄷ
따로 일별로 미션 푸쉬 발송 여부를 디비에 쌓는것도 이상해보여서 로직과 같이 바로 "이전 게시물은 조건 미만족 && 새 게시물 포함하면 미션 조건 만족" 일때 푸쉬 발송하게 해놨는데.. 이론상은 맞는데 혹시 엣지케이스 떠오르는거 있으면 코멘트 부탁드립니다.
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-336