Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-339] feat: 확장된 가족 초대 링크 기능을 구현하기 위한 View API Spec 우선 구현 및 응답 모킹 #260

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

Kwon770
Copy link
Collaborator

@Kwon770 Kwon770 commented Jun 9, 2024

❓ 기능 추가 배경


팀원 일정 조율 상 �3.25차 에 해당하는 가족 초대 링크를 우선 구현하기 위해, 해당 View API의 명세와 응답 모킹을 우선적으로 진행하였습니다. 웹뷰에서의 초대 링크 정보 조회와 앱 내에서의 초대 링크 조회가 거의 대부분 유사하기 때문에 같은 API로 통합하여 구현하였으니, Swagger API Description을 확인해주세요.

➕ 추가/변경된 기능


  • FamilyInviteViewApi, FamilyinviteViewController 추가
  • getFamilyInviteLinkDetails API 명세 구현과 응답 모킹

🥺 리뷰어에게 하고싶은 말


@CChuYong 확인 부탁드려요~

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-339

…troller) and Impl getFamilyInviteLinkDetail api spec and response mocking
@Kwon770 Kwon770 self-assigned this Jun 9, 2024
@github-actions github-actions bot changed the title feat: 확장된 가족 초대 링크 기능을 구현하기 위한 View API Spec 우선 구현 및 응답 모킹 [OING-339] feat: 확장된 가족 초대 링크 기능을 구현하기 위한 View API Spec 우선 구현 및 응답 모킹 Jun 9, 2024
Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jun 9, 2024

Test Results

 51 files  ±0   51 suites  ±0   11s ⏱️ ±0s
142 tests ±0  142 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ddc42fe. ± Comparison against base commit 52e6297.

Copy link

github-actions bot commented Jun 9, 2024

Code Coverage

File Coverage [32.37%]
DeepLinkService.java 65.45%
FamilyInviteViewController.java 27.27%
FamilyInviteDeepLinkResponse.java 0%
Total Project Coverage 52.88% 🍏

Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당 ㅎㅎㅎ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants