Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OING-337] fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 PostType 비교절 제거) #261

Merged
merged 1 commit into from
Jun 9, 2024
Merged

[OING-337] fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 PostType 비교절 제거) #261

merged 1 commit into from
Jun 9, 2024

Conversation

Kwon770
Copy link
Collaborator

@Kwon770 Kwon770 commented Jun 9, 2024 •
edited by github-actions bot
Loading

❓ 기능 추가 배경

위젯에서 미션글은 노출되지 않는 점을 해결하기 위해 작업을 진행하였고, PostRepositoryCustomImpl에서 findLatestPostOfEveryday와 findOldestPostOfEveryday 쿼리에 PostType.eq(SURVIVAL) 절이 의도와 다르게 추가된 점을 발견해 수정하였습니다. 3.0차에 미션을 도입하기 위해 추가한 PostType 컬럼을 도입하며 쿼리들을 리팩토링하는 과정에서 잘못 들어간 것으로 보입니다.

➕ 추가/변경된 기능

  • PostRepositoryCustomImpl의 findOldestPostOfEveryday, findLatestPostOfEveryday 쿼리에서 PostType.eq(SURVIVAL) 비교절 제거

🥺 리뷰어에게 하고싶은 말

🔗 참조 or 관련된 이슈

https://no5ing.atlassian.net/browse/OING-337

@Kwon770
fix: Remove the condition to compare postType equaled with SURVIVAL a…
2c43c86 
…t PostRepositoryCustomImpl to make widget and calendar thumbnail show mission post together
@Kwon770 Kwon770 requested review from CChuYong and Ji-soo708 June 9, 2024 08:05
@Kwon770 Kwon770 self-assigned this Jun 9, 2024
@github-actions github-actions bot changed the title fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 PostType 비교절 제거) [OING-337] fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 PostType 비교절 제거) Jun 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Test Results

 51 files  ±0   51 suites  ±0   11s ⏱️ ±0s
142 tests ±0  142 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c43c86. ± Comparison against base commit 52e6297.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Code Coverage

File Coverage [82.3%] 🍏
PostRepositoryCustomImpl.java 82.3% 🍏
Total Project Coverage 53.06% 🍏

CChuYong
CChuYong approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴다

@CChuYong CChuYong merged commit 06bdb40 into dev Jun 9, 2024
4 checks passed
@CChuYong CChuYong deleted the feature/OING-337 branch June 9, 2024 08:24
CChuYong pushed a commit that referenced this pull request Jun 21, 2024
@Kwon770 @CChuYong
[OING-337] fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 …
a2ec6bd 
…PostType 비교절 제거) (#261)
Ji-soo708 pushed a commit that referenced this pull request Jun 21, 2024
@Kwon770 @Ji-soo708
[OING-337] fix: 위젯에서 미션글도 보이도록 수정 (PostRepositoryCustomImpl에서 잘못 추가된 …
63c6671 
…PostType 비교절 제거) (#261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CChuYong CChuYong CChuYong approved these changes

@Ji-soo708 Ji-soo708 Awaiting requested review from Ji-soo708

Assignees

@Kwon770 Kwon770

Labels
🐛 BUG 버그 ✨ FEATURE 기능 추가 우선순위_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kwon770 @CChuYong