[OING-376] feat: 알림 관련 API 목을 추가해요 #276
Open
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Results114 tests 106 ✅ 9s ⏱️ For more details on these failures, see this check. Results for commit d45697b. |
Kwon770
requested changes
Dec 1, 2024
| String notificationId, | ||
|
|
||
| @Schema(description = "발송자 이미지 url", example = "https://..") | ||
| String senderImageUrl, |
There was a problem hiding this comment.
발송자가 생일인 경우, 프론트 단에서 프로필 스타일을 변경해야 해서 senderMemberId 값도 추가하거나 senderProfileEvent 같은 걸로 알려줘야 합니다.
기존 다른 화면에서는 프론트 선에서 사용자 정보 조회해서 구현하는 방식으로 갔으니 일관성 있게 가는 것도 좋은 것 같습니다. 다만, 사용자 알림마다 사용자 정보를 호출해야하는 파급효과가 있을 것 같네요. 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
음성 댓글에 이어, 알림 관련 API 목을 추가했어요.
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
화이팅!
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-376