fix: 네비게이션 하단 터치시 하이라이트 제거 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrevile
requested review from
Doeunnkimm,
semnil5202,
LeeJeongHooo and
sambad-adventure
as code owners
Doeunnkimm
reviewed
Sep 7, 2024
| @@ -43,11 +43,17 @@ const TabItem = ({ path, title, Icon }: TabItemProps) => { | |||
| css={{ | |||
| flex: '0 1 100%', | |||
| cursor: 'pointer', | |||
| WebkitTapHighlightColor: 'transparent', | |||
There was a problem hiding this comment.
이거 네비 말고도 전역적으로 터치했을 때 보이는 증상같은데, 전역으로 설정하는 거 어떨까요?
There was a problem hiding this comment.
아 요게 터치했을때 깜빡 거리는 것 때문에 추가된건가요?? 👀 저도 전역적으로 설정해도 큰 문제가 없다고 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
https://www.notion.so/depromeet/326f11aa3be84e408c7d0d7eb5a60bc5?pvs=4
🔗 링크
🙏 여기는 꼭 봐주세요!