[BSVR-220] HashTag, BlockTag 도메인/엔티티 추가 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pminsung12
approved these changes
Aug 18, 2024
| @@ -62,7 +62,7 @@ public boolean isDeleted() { | |||
| return this.deletedAt != null; | |||
| } | |||
|
|
|||
| public void setId(Long id) { | |||
| protected void setId(Long id) { | |||
There was a problem hiding this comment.
protected로 바꾼 이유가 뭔지 궁금합니다~!
There was a problem hiding this comment.
setId()가 최대한 해당하는 entity 내부에서만 쓰이길 바랬어!
Id는 절대 바뀌면 안되는 값이고, 따라서 아무데서나 setId()가 의도치않게 호출되지 않도록 제어해야해. 어디서 수정 가능성이 열려있는지도 파악할 수 있어야 하고! setId() 자체를 두지 않는 것이 베스트겠지만 우리는 ReviewImage 등에서 어쩔 수 없이 사용 중이므로....
차선책으로 BaseEntity를 상속하는 클래스들, 즉 Entity 클래스 내부에서만 쓸 수 있도록 접근 레벨을 높였어.
그럼 적어도 Id 관련 변경은 해당 entity 클래스 내에서만 일어날 테니까 변경 책임을 줄일 수 있다고 판단했슴니당
(e.g., ReviewImageEntity 내부에서는 ReviewImageEntity의 Id만 변경 가능! Review의 Id는 변경할 수 없음 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
🌱 연관 내용 (선택)
💻 실행 화면 (필수)