Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO_JIRA] 이미지 파일 이름 받아오는 코드 수정 #153

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

EunjiShin
Copy link
Collaborator

메서드 이름만! 보지 말고! 주석을! 읽자!

삼세번 복창하겠읍니다 죄송합니다 😩

@@ -29,7 +29,7 @@ public class ReviewImageEntity extends BaseEntity {
foreignKey = @ForeignKey(ConstraintMode.NO_CONSTRAINT))
private ReviewEntity review;

@Column(name = "url", nullable = false, length = 255)
@Column(name = "url", nullable = false, length = 1000)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 파일명이 길어서 한글 변환하면 255글자 가볍게 초과하길래... 넉넉히 수정
DB에도 반영해뒀어여

@EunjiShin EunjiShin self-assigned this Aug 20, 2024
@EunjiShin EunjiShin added the 🐛 Bug 버그 label Aug 20, 2024
Copy link

Test Results

45 tests  ±0   45 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
16 files   ±0    0 ❌ ±0 

Results for commit 73424fa. ± Comparison against base commit a911ef2.

Copy link
Collaborator

@pminsung12 pminsung12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

@pminsung12 pminsung12 merged commit 705406e into main Aug 20, 2024
5 checks passed
@pminsung12 pminsung12 deleted the fix/NO_JIRA_admin_review_image_name branch August 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants