[NO_JIRA] 기본 프로필 이미지 변경 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjiShin
reviewed
Aug 28, 2024
Comment on lines
19
to
20
| private final String BASIC_PROFILE_IMAGE_URL = | ||
| "https://spot-image-bucket-v2.s3.ap-northeast-2.amazonaws.com/profile-images/%EA%B8%B0%EB%B3%B8+%ED%94%84%EB%A1%9C%ED%95%84+%EC%9D%B4%EB%AF%B8%EC%A7%80.png"; |
There was a problem hiding this comment.
이거 주소 노출되어도 괜찮나..? 버켓 주소 있으면 보안상 위험할 듯 한데 숨기는거 어때 👀
액세스 정책 같은게 엄청 빡빡하게 세팅되어있지 않기도 하고, 되어있어도 aws 관련 값은 해킹당하면 위험하니까 (우리는! 돈이! 없다!) 안전하게 가면 좋을 것 같어
EunjiShin
reviewed
Aug 28, 2024
| @@ -21,6 +21,9 @@ | |||
| @JsonIgnoreProperties(ignoreUnknown = true) | |||
| public class KakaoUserInfoEntity extends BaseEntity { | |||
|
|
|||
| private final String BASIC_PROFILE_IMAGE_URL = | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
💻 실행 화면 (필수)
설정해둔 기본 프로필이 들어가는 것까지 확인 완료!