feat: 회원가입 로직 개발 및 Button 컴포넌트를 수정합니다. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summermong
requested review from
hjy0951,
Jungjjeong and
wokbjso
as code owners
wokbjso
approved these changes
Aug 12, 2024
Comment on lines
+30
to
+31
| console.log(code); | ||
| console.log(res); |
There was a problem hiding this comment.
console.log가 들어가있어요~~
구글로그인 테스트때문에 넣어뒀던건가요?
There was a problem hiding this comment.
맞습니다 ㅠㅠ 확인하고 지울 예정이에요!
app/join/gender/page.tsx
Outdated
Comment on lines
70
to
74
| className={flex({ | ||
| direction: 'column', | ||
| justifyContent: 'center', | ||
| textAlign: 'center', | ||
| padding: '20px', |
There was a problem hiding this comment.
외부 스타일 주입이 아닌 스타일 적용은 buttonStyles 처럼 따로 빼는거도 괜찮을 것 같아요!
app/join/gender/page.tsx
Outdated
| import { flex } from '@/styled-system/patterns'; | ||
|
|
||
| export interface GenderData { | ||
| gender: string; |
There was a problem hiding this comment.
gender는 남자 or 여자 둘 중 하나이기 떄문에 모든 string 타입을 열어두는거 보다는 'W' | 'M' 으로 선언해 주는게 좋을 것 같아요!
king2dwellsang
added
Approved 🆗
hjy0951
approved these changes
Aug 12, 2024
Comment on lines
+35
to
+36
| console.log('전달한 코드:', JSON.stringify({ code: GOOGLE_CODE })); | ||
| console.log('응답:', response); |
There was a problem hiding this comment.
이 console 들도 빠져야할 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
2024-08-10.1.08.12.mov
2024-08-10.1.14.47.mov
이런 식으로 className을 string으로 입력하면 variant, buttonType를 지정해도 추가로 스타일링이 적용됩니다.