Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 친구 추천 기능을 구현합니다. #461

Merged
merged 13 commits into from
Nov 26, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Nov 26, 2024

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • 친구 추천 기능을 여러 페이지에 구현하였습니다.

📷 이미지 첨부 (Option)

  • 마이페이지
default.mp4
  • 빈 소식 페이지
default.mp4
  • 친구 찾기 페이지
default.mp4

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added feat # Add feature Review Plz🙏 # Review is not yet complete labels Nov 26, 2024
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 넘 굿굿
나중에 추천 데이터 api 연동이 필요하게 된다면, useSuspenseQuery 사용해봐도 좋겠네요

variant="outlined"
buttonType="primary"
className={css({ w: 'full' })}
onClick={handleClickFollow}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button은 동일하게 쓰되
label, buttonType만 isFollowing에 따라 분기쳐도 좋을 것 같아요

const getIsMyProfile = (memberId: number) => {
if (!myData?.data) return false;
const myMemberId = myData?.data.id;
return myMemberId === memberId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memberId가 꼭 들어온다는 가정 하에
myData?.data?.id === memberId
로만 작성해도 false, true가 반환될 것 같아요

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Nov 26, 2024
@wokbjso wokbjso merged commit 5e1cd7d into main Nov 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants