Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : redis cache 관련 테스트 수정 #23

Merged
merged 3 commits into from
May 13, 2023
Merged

fix : redis cache 관련 테스트 수정 #23

merged 3 commits into from
May 13, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented May 12, 2023 •
edited
Loading

개요

작업사항

  • AOP 만들 때 join...point 리턴 값이 Any? 여야하네요....
  • 추가적으로 cacheable 되어있는 어노테이션...
  • 테스트 반복해서 돌리면 깨지더라고요
  • 처음은 잘되는데 일단 주석처리하고 나중에 함 다시 보겠습니다.
    --->>
    레디스 캐시관련해서 고쳤슴다
    관련 레퍼런스

원래 코틀린이 잘 안됐었나 봐유

변경로직

  • 내용을 적어주세요.

@ImNM ImNM self-assigned this May 12, 2023
@ImNM ImNM requested review from BlackBean99 and kdomo as code owners May 12, 2023 12:05
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ImNM ImNM changed the title fix : redis cache 관련 테스트 주석 처리 fix : redis cache 관련 테스트 수정 May 12, 2023
kdomo
kdomo approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당

Whatnow-Domain/src/main/kotlin/com/depromeet/whatnow/common/aop/event/EventPublisherAspect.kt
fun handleEvent(joinPoint: ProceedingJoinPoint): Any {
fun handleEvent(joinPoint: ProceedingJoinPoint): Any? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러가 발생한건가용? joinPoint가 null이 반환될수있어서 그런거죠..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예압...!

Whatnow-Infrastructure/src/main/kotlin/com/depromeet/whatnow/config/redis/RedisCacheConfig.kt
),
RedisSerializationContext.SerializationPair
.fromSerializer(
GenericJackson2JsonRedisSerializer(objectMapper),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

objectmapper 추가 확인

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦어서 미안합니당ㅎ

@ImNM ImNM merged commit 5360d30 into develop May 13, 2023
@ImNM ImNM deleted the fix/aop-joinpoint-error branch May 13, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackBean99 BlackBean99 BlackBean99 approved these changes

@kdomo kdomo kdomo approved these changes

Assignees

@ImNM ImNM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix : aop joinpoint error 관련 수정
3 participants
@ImNM @BlackBean99 @kdomo