Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOG_CRITICAL macro #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregoireborel
Copy link

No description provided.

@cyberbobs
Copy link
Member

Well... Doesn't LOG_ERROR macro meet your needs? qCritical is mapped to LOG_ERROR level and means basically the same. IMO every serious error could be considered critical in the production environments.

I understand that different projects have its own workflow and our set of log levels may not be suitable for every single project out there. But at the moment we are trying to keep things as simple and dumb as possible. Otherwise the better possible solution will be the ability to add custom log levels to CuteLogger but I'm not really sure, whether there is a real need for this kind of functionality.

Please share your thoughts on this, maybe we will consider adding this kind of functionality in the future.

@cyberbobs cyberbobs self-assigned this Jun 10, 2016
@gregoireborel
Copy link
Author

Since there is a qCritical macro, I thought it would be natural to use LOG_CRITICAL. But I was just being nitpicky, you are right in the sense that we don't really need it. Your remark about the idea that every serious error could be considered critical in the production environments is totally sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants