Qt6 fixes #36
Open
Qt6 fixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QTime::elapsed() is deprecated in recent Qt5, and removed in Qt6. Use QElapsedTimer instead, which is the suggested replacement.
vsprintf() is deprecated in recent Qt5, and removed in Qt6. Its replacement vasprintf() is available since Qt 5.5.
fromTime_t has been deprecated and removed from Qt6. Use the replacement fromSecsSinceEpoch() on Qt 5.8+.
QRegExp is deprecated in recent Qt, and has been removed in Qt6. Use the replacement QRegularExpression.
fromList() is deprecated and has been removed in Qt6. Since Qt 5.14 range constructors are available, use those instead.
|
Hello, thank you for the contribution. It will take some time to review and check (current test coverage is lacking, so there will be some serious manual checking). I'll try to get my hands on this next week. Will keep you posted. |
Closed
FileAppender will no longer call QFile::flush on every message write due to it dramatically slowing apps when writing a lot of log records to slow file system. The downside is some log data may be lost if application crashes before QFile manages to write all of the buffered data to file system. It is still possible to revert to an old behavior calling setFlushOnWrite(true) on FileAppender.
CMake started showing deprecation warning about CMake 2.8 files support.
Qt6 moves QTextCodec to the Qt5Compat module. Since it's unused anyway remove it so we don't get the dependency on Qt5Compat.
Getting the values from a QMultiMap() returns a list, but not the same on consecutive calls. Thus calling it twice to get the iterators will yield different lists, causing the iterator to fail. Fixes segfault when destructing the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace obsolete classes and functions with their replacements, making it compile with current Qt6 preview.