fix: update affected projects check in release workflow (#874)

## Related Issues Fixes descope/etc#8715 ## Description Updated the condition in the release-next-react-sdk workflow to check for affected projects using the correct base and head references. This ensures that the workflow accurately determines if the 'react-sdk' or 'web-component' projects are affected by recent changes. --------- Co-authored-by: tomski747 <[email protected]>
descope · Dec 24, 2024 · 7311ea7 · 7311ea7
1 parent f6c19b5
commit 7311ea7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/release-next-react-sdk.yml b/.github/workflows/release-next-react-sdk.yml
@@ -48,7 +48,8 @@ jobs:
       - name: Check if should run
         id: 'check'
         run: |
-          if $(npx nx show projects --affected --plain | grep -q "react-sdk\|web-component"); then
+          # Check if the affected projects include "react-sdk" or "web-component" since the last commit
+          if $(npx nx show projects --affected --base HEAD~1 --head HEAD | grep -q "react-sdk\|web-component"); then
             echo "run=true" >> $GITHUB_OUTPUT
           else
             echo "run=false" >> $GITHUB_OUTPUT

diff --git a/packages/sdks/react-sdk/src/types.ts b/packages/sdks/react-sdk/src/types.ts
@@ -113,7 +113,7 @@ export type DescopeProps = {
   tenant?: string;
   // If theme is not provided - the OS theme will be used
   theme?: ThemeOptions;
-  // Unless locale is provided - the browser's locale will be used
+  // If locale is not provided - the browser's locale will be used
   locale?: string;
   autoFocus?: AutoFocusOptions;
   validateOnBlur?: boolean;