Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add style id to react sdk #782

Merged
merged 4 commits into from
Aug 22, 2024
Merged

chore: add style id to react sdk #782

merged 4 commits into from
Aug 22, 2024

Conversation

Bars92
Copy link
Member

@Bars92 Bars92 commented Aug 21, 2024

Related Issues

related https://github.com/descope/etc/issues/4875

Related PRs

#744

Description

  • add styleId to react sdk
  • add test
  • add readme details

Must

  • Tests
  • Documentation (if applicable)

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:49am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:49am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:49am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:49am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:49am

Copy link

nx-cloud bot commented Aug 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e631aa0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

nirgur
nirgur previously approved these changes Aug 21, 2024
Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Added one small comment

@Bars92 Bars92 enabled auto-merge (squash) August 22, 2024 09:45
@Bars92 Bars92 deleted the style_id_prop branch August 22, 2024 09:52
@Bars92 Bars92 mentioned this pull request Nov 3, 2024
2 tasks
Bars92 added a commit that referenced this pull request Nov 4, 2024
## Related Issues
descope/etc#4875

## Related PRs
#782

## Description
add style id to angular
add style id to all widgets in angular, vue and react

## Must

- [x] Tests
- [ ] Documentation (if applicable)

Co-authored-by: Doron Sharon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants