fix: return sdk script results after conditional UI #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit a5b6878.
☁️ Nx Cloud last updated this comment at |
asafshen
requested review from
shilgapira and
nirgur
and removed request for
talaharoni
nirgur
reviewed
Jan 2, 2025
There was a problem hiding this comment.
I’m not sure I understand the problem and how this change solves it
Can you please elaborate?
There was a problem hiding this comment.
the problem is that after biometrics auto-fill (which trigger this next(...) call) - sdk scripts (such as forter/fingerprint) don't work
the reason that they don't work is because we don't send their state like on other "regular" next calls
@nirgur if you prefer we can talk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/8612
Description
return sdk script results after conditional UI (passkeys)