Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle close timeouts #887

Draft
wants to merge 5 commits into
base: chore-refactor-timeout-code
Choose a base branch
from

Conversation

asafshen
Copy link
Member

Related Issues

Fixes https://github.com/descope/etc/issues/8912
Fixes https://github.com/descope/etc/issues/7424

Description

handle too close timeouts in the following ways

  • after auth request - if calculated timeout is less than 20 seconds - do not set refresh timeout
  • when window becomes visible - do not refresh if refresh failed

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:37pm
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:37pm
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:37pm
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:37pm
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:37pm

Copy link

nx-cloud bot commented Jan 13, 2025

View your CI Pipeline Execution ↗ for commit 25783e9.

Command Status Duration Result
nx affected --target test ❌ Failed 2m 41s View ↗
nx affected --target lint --fix=true ✅ Succeeded 5s View ↗
nx affected --target build ✅ Succeeded 2m 28s View ↗
nx affected --target licenseCheck ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-13 15:40:05 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant