add additional login ids to mgmt cli #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviadl
previously approved these changes
Dec 18, 2023
dorsha
requested changes
Dec 18, 2023
dorsha
approved these changes
Dec 18, 2023
shilgapira
reviewed
Dec 18, 2023
| user.Phone = flags.Phone | ||
| if flags.Email == "" && flags.Phone == "" { | ||
| user.Email = "[email protected]" // email or phone are required |
There was a problem hiding this comment.
user.Email = "[email protected]" // email or phone are requiredWhy are we not just throwing an error?
There was a problem hiding this comment.
thought about this as well, but it makes the API of the cli a bit more complex, I believe that this is the reason we add the default email in the first place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lmk what you think