Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip certificate validation only for development server baseURLs #342

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Skip certificate validation only for development server baseURLs #342

merged 3 commits into from
Dec 19, 2023

Conversation

shilgapira
Copy link
Member

Related Issue

Fixes https://github.com/descope/etc/issues/4996

Description

  • Change default behavior to only skip certificate validation when overriding the server baseURL with the address of a development environment
  • Allow clients to decide to override behavior to always or never validate server certificate

Must

  • Tests
  • Documentation (if applicable)

@shilgapira shilgapira self-assigned this Dec 15, 2023
@shilgapira shilgapira enabled auto-merge (squash) December 15, 2023 15:46
aviadl
aviadl reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@aviadl aviadl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the PR I did
Not sure we need this one ...

dorsha
dorsha previously approved these changes Dec 19, 2023
View reviewed changes
@dorsha
Copy link
Member

dorsha commented Dec 19, 2023

Let's go for this solution for simplicity and security.

@shilgapira shilgapira requested a review from dorsha December 19, 2023 11:35
dorsha
dorsha previously approved these changes Dec 19, 2023
View reviewed changes
@shilgapira shilgapira merged commit 96e46a5 into main Dec 19, 2023
5 checks passed
@shilgapira shilgapira deleted the cert-validate branch December 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviadl aviadl aviadl left review comments

@dorsha dorsha dorsha approved these changes

@meirwah meirwah Awaiting requested review from meirwah

@Bars92 Bars92 Awaiting requested review from Bars92

Assignees

@shilgapira shilgapira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilgapira @dorsha @aviadl