Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new SSO logic #356

Merged
merged 12 commits into from
Dec 31, 2023
Merged

Support new SSO logic #356

merged 12 commits into from
Dec 31, 2023

Conversation

guyp-descope
Copy link
Contributor

Description

Support the new SSO logic which include the following:

  • Auth SDK:
    • Auth.SAML().Start(..) will now act based on tenant authType method (saml or oidc)
    • The above SAML interface is now marked as deprecated
    • Added new SSOSP interface with the same logic as SAML interface (which also act based on tenant authType method
      (saml or oidc))
  • Management SDK:
    • Marked the following functions as deprecated:
      Management.SSO().GetSettings(..), Management.SSO().ConfigureSettings(..), Management.SSO().ConfigureMetadata(..), Management.SSO().ConfigureMetadata(..)
    • Created the new saml/oidc configuration function:
      • Load tenant authentication configuration: Management.SSO().LoadSettings(..)
      • Set new tenant authentication configuration:
        • Saml: Management.SSO().ConfigureSAMLSettings(..)
        • Saml by using metadata: Management.SSO().ConfigureSAMLSettingsByMetadata(..)
        • Oidc: Management.SSO().ConfigureOIDCSettings(..)

Must

  • Tests
  • Documentation (if applicable)

@guyp-descope guyp-descope marked this pull request as ready for review December 21, 2023 22:20
Copy link
Member

@dorsha dorsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Few comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
descope/api/client.go Outdated Show resolved Hide resolved
descope/api/client.go Outdated Show resolved Hide resolved
descope/sdk/auth.go Outdated Show resolved Hide resolved
descope/internal/mgmt/sso.go Show resolved Hide resolved
descope/internal/mgmt/sso.go Show resolved Hide resolved
@guyp-descope guyp-descope requested a review from dorsha December 26, 2023 21:23
@guyp-descope
Copy link
Contributor Author

I merge this branch with the main branch that includes the multiple domains and now everything is aligned. please rereview

dorsha
dorsha previously approved these changes Dec 26, 2023
@guyp-descope guyp-descope merged commit fb36ceb into main Dec 31, 2023
5 checks passed
@guyp-descope guyp-descope deleted the support-new-sso-logic branch December 31, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants