Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor session management bug fixes #82

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Minor session management bug fixes #82

merged 3 commits into from
Jan 1, 2025

Conversation

shilgapira
Copy link
Member

Description

  • Minor documentation fixes
  • Fix handling of failures in periodic refresh to stop refresh attemps on non-network failures
  • Fix session being saved to storage even when not refreshed

Must

  • Tests
  • Documentation (if applicable)

@shilgapira shilgapira requested a review from itaihanski January 1, 2025 13:35
@shilgapira shilgapira self-assigned this Jan 1, 2025
@shilgapira shilgapira enabled auto-merge (squash) January 1, 2025 13:35
@shilgapira shilgapira merged commit ec9524f into main Jan 1, 2025
1 check passed
@shilgapira shilgapira deleted the changes branch January 1, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaihanski itaihanski itaihanski approved these changes

Assignees

@shilgapira shilgapira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilgapira @itaihanski