Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session lifecycle updates #83

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Session lifecycle updates #83

merged 4 commits into from
Jan 7, 2025

Conversation

shilgapira
Copy link
Member

Related Issues

Fixes https://github.com/descope/etc/issues/8865

Description

  • Update SessionLifecycle to not perform periodic refresh calls with tokens that seem to have expired
  • Update SessionLifecycle to save refreshed sessions to storage to ensure rotated refresh tokens are preserved
  • Fixed issue with empty tokens in refresh response
  • Added shouldSaveAfterPeriodicRefresh flag to SessionLifecycle to disable automatic saving (enabled by default)
  • Added accessibility flag to SessionStorage.KeychainStore class to allow changing when the saved session can be accessed by the app (accessibleAfterFirstUnlock by default)

Must

  • Tests
  • Documentation (if applicable)

@shilgapira shilgapira requested a review from itaihanski January 7, 2025 17:52
@shilgapira shilgapira self-assigned this Jan 7, 2025
@shilgapira shilgapira merged commit 0d71359 into main Jan 7, 2025
1 check passed
@shilgapira shilgapira deleted the session-updates branch January 7, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants