Skip to content

Commit

Permalink
Updating RC to 5 to fix FFMPEG dependency on mac
Browse files Browse the repository at this point in the history
  • Loading branch information
srikanth-descript committed Dec 20, 2023
1 parent ddbc0c5 commit 344815b
Show file tree
Hide file tree
Showing 4 changed files with 532 additions and 1,441 deletions.
2 changes: 1 addition & 1 deletion binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}],
["OS=='mac'", {
"variables": {
"ffmpeg_version": "1.33rc3",
"ffmpeg_version": "1.49.rc.1",
"target_arch_override": "<!(node -p \"'<(target_arch)' === 'x64' ? 'x86_64' : '<(target_arch)'\")",
},
"defines": [
Expand Down
6 changes: 3 additions & 3 deletions install_ffmpeg.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,10 @@ async function darwin() {
else throw e;
});

const version = '1.33rc3';
const version = '1.49.rc.1';

// default to platform-architecture
let arch = os.arch()
let arch = os.arch();

// but if the '--arch' argument is provided
// use the next argument as the value (e.g. 'x64' or 'arm64')
Expand All @@ -206,7 +206,7 @@ async function darwin() {
}

const ffmpegFilename = `ffmpeg-ffprobe-shared-darwin-${arch}.${version}`;
const tag = `v${version}`
const tag = `v${version}`;

await access(`ffmpeg/${ffmpegFilename}`, fs.constants.R_OK).catch(async () => {
const ws = fs.createWriteStream(`ffmpeg/${ffmpegFilename}.zip`);
Expand Down
Loading

0 comments on commit 344815b

Please sign in to comment.