Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposal details scroll #259

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Conversation

manu0466
Copy link

@manu0466 manu0466 commented Nov 7, 2023

Description

Closes: DPM-175

This PR fixes a bug that prevent the user from scrolling the proposal details.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

  • included the correct type prefix in the PR title
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed

@manu0466 manu0466 added Type: Bug Something isn't working C: UI Related to the visual aspect of the app P: iOS Related to iOS side automerge Related to mergify labels Nov 7, 2023
@manu0466 manu0466 requested a review from RiccardoM November 7, 2023 09:07
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/lib/FormatUtils/index.ts 40.47% <0.00%> (-0.99%) ⬇️

📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Nov 7, 2023

SonarQube Quality Gate Result

  • Result: ✅ OK
  • Triggered by @mergify[bot] on pull_request
Metric Status Value Error Threshold
New reliability rating ✅ OK 1 > 1
New security rating ✅ OK 1 > 1
New maintainability rating ✅ OK 1 > 1
New duplicated lines density ✅ OK 1.62 > 3
New security hotspots reviewed ✅ OK 100 < 100

View on SonarQube

updated: 11/7/2023, 11:12:05 (UTC+0)

Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit b467b1a into main Nov 7, 2023
@mergify mergify bot deleted the manuel/fix-proposal-details-scroll branch November 7, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Related to mergify C: UI Related to the visual aspect of the app P: iOS Related to iOS side Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants