Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the new safe area context lib #261

Merged
merged 10 commits into from
Nov 7, 2023

Conversation

manu0466
Copy link

@manu0466 manu0466 commented Nov 7, 2023

Description

Closes: #XXXX

This PR updates react-native-safe-area-context to version 4.7.4 and uses the provided SafeAreaView from this package in the StyledSafeAreaView. This is necessary to ensure proper screen and button visualization when the keyboard opens on the new iPhone.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

  • included the correct type prefix in the PR title
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed

@manu0466 manu0466 added Type: Enhancement New feature or request C: UI Related to the visual aspect of the app P: iOS Related to iOS side P: Android Reletaed to the Android side automerge Related to mergify labels Nov 7, 2023
@manu0466 manu0466 requested a review from RiccardoM November 7, 2023 16:53
Copy link

github-actions bot commented Nov 7, 2023

SonarQube Quality Gate Result

  • Result: ✅ OK
  • Triggered by @mergify[bot] on pull_request
Metric Status Value Error Threshold
New reliability rating ✅ OK 1 > 1
New security rating ✅ OK 1 > 1
New maintainability rating ✅ OK 1 > 1
New duplicated lines density ✅ OK 1.62 > 3
New security hotspots reviewed ✅ OK 100 < 100

View on SonarQube

updated: 11/7/2023, 17:06:51 (UTC+0)

@manu0466 manu0466 removed the P: Android Reletaed to the Android side label Nov 7, 2023
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@mergify mergify bot merged commit 5fd75c2 into main Nov 7, 2023
@mergify mergify bot deleted the manuel/update-safe-area-context branch November 7, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Related to mergify C: UI Related to the visual aspect of the app P: iOS Related to iOS side Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants