Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark #28

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add benchmark #28

merged 2 commits into from
Jan 22, 2024

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Jan 22, 2024 •
edited
Loading

fixes #20

@sungam3r sungam3r added the performance Issue or pull request about performance problems label Jan 22, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2024
View reviewed changes
src/Benchmarks/JsonNetBenchmarks.cs
Arr = new[] { 1, 2, 3 },
S = "Some string",
D = new Dictionary<int, string> { { 1, "One" }, { 2, "Two" } },
E = (object?)null,

Check warning

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
null
Loading
to
Object
Loading
- the conversion can be done implicitly.
@sungam3r sungam3r merged commit b3950ef into master Jan 22, 2024
6 checks passed
@sungam3r sungam3r deleted the bench branch January 22, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Issue or pull request about performance problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add benchmarks
1 participant
@sungam3r